Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Upgrade surefire plugin and remove workarounds #4787

Merged
merged 5 commits into from
Jun 26, 2020
Merged

Upgrade surefire plugin and remove workarounds #4787

merged 5 commits into from
Jun 26, 2020

Conversation

kornys
Copy link
Member

@kornys kornys commented Jun 22, 2020 •
edited
Loading

Type of change

  • Refactoring

Description

Checklist

  • Upgrade surefire and junit jupiter version
  • Remove workarounds
  • Fix failed imports from old junit
  • Fix PR message parsing
  • Run full regression

@kornys kornys requested review from lulf and ctron June 22, 2020 07:11
@kornys kornys self-assigned this Jun 22, 2020
lulf
lulf reviewed Jun 22, 2020
View reviewed changes
Copy link
Member

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to wait after 0.32 branch? Now that we finally have systemtests running somewhat reliably, I'm a bit worried with another round of destabilization.

@kornys
Copy link
Member Author

kornys commented Jun 22, 2020

@lulf after release, anyway seems they have another issue in surefire and I'm not abl to run tests with m5 :D

@kornys
Copy link
Member Author

kornys commented Jun 22, 2020

@lulf @ctron PR is ready for merge from my POV, right now I'm not sure if we can merge it, it should not affects tests because with surefire-M5 it should finally catch all exception in test lifecycle methods

@kornys
Copy link
Member Author

kornys commented Jun 22, 2020

@enmasse-ci run tests profile=smoke test_only

@enmasse-ci
Copy link

❗ Build Failed ❗

@kornys
Copy link
Member Author

kornys commented Jun 22, 2020

@enmasse-ci run tests profile=smoke test_only

@kornys kornys requested a review from lulf June 22, 2020 18:40
@kornys kornys added this to the 1.0.0 milestone Jun 22, 2020
@kornys
Copy link
Member Author

kornys commented Jun 22, 2020

@ctron @lulf I fixed wrong imports from old junit library which Jens added into systemtests, so now it should work without workarounds :-)

@kornys kornys force-pushed the upgrade-surefire-m5 branch from 3866765 to 31263f0 Compare June 22, 2020 18:46
@kornys
Copy link
Member Author

kornys commented Jun 22, 2020

@enmasse-ci run tests profile=smoke test_only

@EnMasseProject EnMasseProject deleted a comment from enmasse-ci Jun 22, 2020
@enmasse-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: smoke
TEST_CASE:
TOTAL: 3
PASS: 3
FAIL: 0
SKIP: 0
BUILD_NUMBER: 1081
BUILD_ENV: oc cluster up

@kornys
Copy link
Member Author

kornys commented Jun 24, 2020

@enmasse-ci run tests profile=smoke test_only crc

@kornys kornys force-pushed the upgrade-surefire-m5 branch from f293f9d to efd90cf Compare June 24, 2020 10:29
@kornys
Copy link
Member Author

kornys commented Jun 24, 2020

@enmasse-ci run tests profile=smoke test_only crc

@enmasse-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: smoke
TEST_CASE:
TOTAL: 3
PASS: 3
FAIL: 0
SKIP: 0
BUILD_NUMBER: 1110
BUILD_ENV: crc

@kornys kornys force-pushed the upgrade-surefire-m5 branch from 66cba10 to 3feffdf Compare June 26, 2020 06:58
@kornys
Copy link
Member Author

kornys commented Jun 26, 2020

@enmasse-ci run tests profile=iot testcase=HttpAdapterTest crc test_only

@enmasse-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: iot
TEST_CASE: HttpAdapterTest
TOTAL: 6
PASS: 6
FAIL: 0
SKIP: 0
BUILD_NUMBER: 1124
BUILD_ENV: crc

@kornys kornys merged commit 6994945 into master Jun 26, 2020
@kornys kornys deleted the upgrade-surefire-m5 branch June 26, 2020 09:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lulf lulf lulf approved these changes

@ctron ctron Awaiting requested review from ctron

Assignees

@kornys kornys

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kornys @enmasse-ci @lulf