Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Add MessagingPlan and MessagingAddressPlan types #4771

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Add MessagingPlan and MessagingAddressPlan types #4771

merged 1 commit into from
Jun 30, 2020

Conversation

lulf
Copy link
Member

@lulf lulf commented Jun 18, 2020

Basic skeleton for these types.

@lulf lulf requested a review from vbusch June 18, 2020 11:40
@lulf lulf force-pushed the plan-types-shared-infra branch from 810db8c to 25a75ff Compare June 18, 2020 11:54
k-wall
k-wall previously approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@k-wall k-wall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@lulf lulf force-pushed the plan-types-shared-infra branch from 6d72c89 to 83c9667 Compare June 26, 2020 11:41
@lulf lulf requested a review from k-wall June 26, 2020 15:58
@lulf lulf force-pushed the plan-types-shared-infra branch from 83c9667 to 6163406 Compare June 29, 2020 20:26
@lulf lulf merged commit 25413b0 into master Jun 30, 2020
@lulf lulf deleted the plan-types-shared-infra branch June 30, 2020 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vbusch vbusch Awaiting requested review from vbusch

@k-wall k-wall Awaiting requested review from k-wall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lulf @k-wall