Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

[Shared infra] Add support for deadletter and expiry settings #4767

Merged
merged 1 commit into from
Jun 23, 2020
Merged

[Shared infra] Add support for deadletter and expiry settings #4767

merged 1 commit into from
Jun 23, 2020

Conversation

lulf
Copy link
Member

@lulf lulf commented Jun 18, 2020

Type of change

  • Enhancement / new feature

Description

Default settings are set to broker defaults, except broker full
policy, which is set to FAIL. More settings will be exposed at a later
point.

Add systemtests for deadletter and expiry behavior, modify the AMQP
client to be able to reject messages so that they end up in the dead
letter queue.

Make more tests run in multiple Kubernetes environments by retrieving
a node ip and using nodeport to expose service.

Issue #4469

Checklist

  • Update/write design documentation in ./documentation/design
  • Write tests and make sure they pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

@lulf
Copy link
Member Author

lulf commented Jun 18, 2020

@enmasse-ci run tests profile=isolated-shared-infra testcase=MessagingAddressTest

@enmasse-ci
Copy link

❗ Build Failed ❗

@lulf lulf force-pushed the dead-letter-expiry-support branch from 4320bed to 24121b6 Compare June 18, 2020 09:51
@lulf
Copy link
Member Author

lulf commented Jun 18, 2020

@enmasse-ci run tests profile=isolated-shared-infra testcase=MessagingAddressTest

@enmasse-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: isolated-shared-infra
TEST_CASE: MessagingAddressTest
TOTAL: 31
PASS: 31
FAIL: 0
SKIP: 0
BUILD_NUMBER: 1042
BUILD_ENV: oc cluster up

@lulf
Copy link
Member Author

lulf commented Jun 18, 2020

@enmasse-ci run tests profile=isolated-shared-infra testcase=MessagingAddressTest crc

@lulf lulf requested review from kornys and k-wall June 18, 2020 11:29
@enmasse-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: isolated-shared-infra
TEST_CASE: MessagingAddressTest
TOTAL: 31
PASS: 31
FAIL: 0
SKIP: 0
BUILD_NUMBER: 1045
BUILD_ENV: crc

@lulf
Copy link
Member Author

lulf commented Jun 18, 2020

@enmasse-ci run tests profile=isolated-shared-infra

@enmasse-ci
Copy link

❌ Test Summary ❌

TEST_PROFILE: isolated-shared-infra
TEST_CASE:
TOTAL: 44
PASS: 37
FAIL: 3
SKIP: 4
BUILD_NUMBER: 1046
BUILD_ENV: oc cluster up

❗ Test Failures ❗

  • testDefaultInfra in io.enmasse.systemtest.sharedinfra.DefaultsTest
  • testInfraRestart in io.enmasse.systemtest.sharedinfra.MessagingInfrastructureTest
  • testInfraStaticScalingStrategy in io.enmasse.systemtest.sharedinfra.MessagingInfrastructureTest

@lulf
Copy link
Member Author

lulf commented Jun 18, 2020

@enmasse-ci run tests profile=isolated-shared-infra

@enmasse-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: isolated-shared-infra
TEST_CASE:
TOTAL: 51
PASS: 47
FAIL: 0
SKIP: 4
BUILD_NUMBER: 1048
BUILD_ENV: oc cluster up

@lulf
Copy link
Member Author

lulf commented Jun 18, 2020

@enmasse-ci run tests profile=isolated-shared-infra crc

@enmasse-ci
Copy link

✔️ Test Summary ✔️

TEST_PROFILE: isolated-shared-infra
TEST_CASE:
TOTAL: 51
PASS: 47
FAIL: 0
SKIP: 4
BUILD_NUMBER: 1049
BUILD_ENV: crc

k-wall
k-wall suggested changes Jun 22, 2020
View reviewed changes
Copy link
Member

@k-wall k-wall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one trivial comment only.

@lulf
Add support for deadletter and expiry settings
686f4a3 
Default settings are set to broker defaults, except broker full
policy, which is set to FAIL. More settings will be exposed at a later
point.

Add systemtests for deadletter and expiry behavior, modify the AMQP
client to be able to reject messages so that they end up in the dead
letter queue.

Make more tests run in multiple Kubernetes environments by retrieving
a node ip and using nodeport to expose service.

Issue EnMasseProject#4469
@lulf lulf force-pushed the dead-letter-expiry-support branch from 24121b6 to 686f4a3 Compare June 22, 2020 16:48
@lulf lulf requested a review from k-wall June 22, 2020 16:48
@lulf lulf merged commit 97de89a into EnMasseProject:master Jun 23, 2020
@lulf lulf deleted the dead-letter-expiry-support branch June 23, 2020 08:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@k-wall k-wall k-wall approved these changes

@kornys kornys Awaiting requested review from kornys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lulf @enmasse-ci @k-wall