Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Fix 404 when using a tenant outside of the enmasse namespace #3442

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Nov 7, 2019

Type of change

  • Bugfix

Description

Since the upgrade to fabric8, all IoT tests fail due to unknown tenants. It looks
like fabric8 changed it behavior, to apply a default namespace ot the client, which
makes the client only watch for tenants in the current namespace of the infrastructure.

This change explicitly enables "any" namespace.

Checklist

  • Update/write design documentation in ./documentation/design
  • Write tests and make sure they pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md

@ctron ctron requested review from dejanb and k-wall November 7, 2019 10:25
@ctron
Copy link
Contributor Author

ctron commented Nov 7, 2019

@enmasse-ci run tests profile=iot

@ctron
Copy link
Contributor Author

ctron commented Nov 7, 2019

@enmasse-ci run tests profile=iot

@enmasse-ci
Copy link

Build Failed

Copy link
Contributor

@dejanb dejanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the fix manually. It works again now.

@ctron
Copy link
Contributor Author

ctron commented Nov 7, 2019

Peeking at the console of the jenkins job, it also looks like the changes @k-wall made to the systemtests work. Let's wait for the tests to complete and with a bit of luck everything should be back 💚

@k-wall
Copy link
Member

k-wall commented Nov 7, 2019

For the record, the regression when deleting an object loaded from a local resource fabric8io/kubernetes-client#1856

@enmasse-ci
Copy link

❌ Test Summary ❌

TEST_PROFILE: iot
TEST_CASE:
TOTAL: 34
PASS: 29
FAIL: 1
SKIP: 4

❗ Test Failures ❗

  • testCreate in io.enmasse.systemtest.iot.isolated.IoTProjectManagedTest

@ctron ctron merged commit 28ce922 into EnMasseProject:master Nov 7, 2019
@ctron ctron deleted the feature/fix_missing_tenant_1 branch November 7, 2019 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants