cleanup webpacks #396
Merged
cleanup webpacks #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastienGllmt
force-pushed
the
feature/bundle_optimize
branch
2 times, most recently
from
b1a26ba to
287b7a9
Compare
SebastienGllmt
force-pushed
the
cleanup/webpack
branch
from
37394c2 to
bda8d9c
Compare
vsubhuman
reviewed
Apr 11, 2019
| @@ -11,4 +11,4 @@ tasks.copyAssets('build', argv.env); | |||
| console.log('[Webpack Build]'); | |||
| console.log('-'.repeat(80)); | |||
|
|
|||
| exec(`./node_modules/.bin/webpack --config webpack/${argv.env}.config.js --progress --profile --colors`); | |||
| exec(`./node_modules/.bin/webpack --config webpack/prodConfig.js --progress --profile --colors --env=${argv.env}`); | |||
There was a problem hiding this comment.
So I don't get it, why we always use prodConfig? Even when env might be dev
There was a problem hiding this comment.
the build.js is purely for production builds.
The dev environment has absolutely nothing to do with development builds. Having a network type dev was all a hack used in Icarus to get it to load up the right manifest file that allows connection to localhost.
vsubhuman
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to learn the webpack configs to do #386 so I decided to do some cleanup at the same time too. Basically we had a bunch of webpack files which were all copy/pastes of each other with one string changes so I simplified it to just two:
prodanddevNote: this is unrelated to the
dev:mainnetissue since to fix that we need to fixup the way we handle manifest files.Note: This PR is on a long chain of dependencies and not on
developso be careful about merging it. I made this a separate PR from #386 to make the diff easier to read.