Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove descriptions #361

Merged
merged 2 commits into from
Mar 20, 2019
Merged

Fix/remove descriptions #361

merged 2 commits into from
Mar 20, 2019

Conversation

SebastienGllmt
Copy link
Contributor

I remove the description for all i18n strings.

These descriptions were basically always out-of-date or lazily copy-pasted and they provide no benefit because our translation team can't even seen them anyway.

Let's just get rid of the bloat and delete them all 👍

@SebastienGllmt SebastienGllmt added the NFC No Functional Change (pure refactoring/cleanup) label Mar 20, 2019
@SebastienGllmt SebastienGllmt requested a review from shinsuny March 20, 2019 11:47
@SebastienGllmt SebastienGllmt merged commit 30a3ae7 into develop Mar 20, 2019
@SebastienGllmt SebastienGllmt deleted the fix/removeDescriptions branch March 20, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NFC No Functional Change (pure refactoring/cleanup)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants