Feature/remove word button #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/components/wallet/backup-recovery/WalletRecoveryPhraseEntryDialog.js
Outdated
Show resolved
Hide resolved
|
I'm not super convinced about having a big "Remove last" button for the UI. It feels like it should be a tiny button somewhere but idk what would be the best UI for the least amount of work. |
vsubhuman
approved these changes
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the 'confirm' button to a 'remove last' button.
Before this change, when
enteredPhrasewas true, the page automatically passed to the next dialog as the 'confirm' button actually wasn't used.