[fix/4.22.100] Ledger app 5 catalyst registration adaptation #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[autoscirpt] Jira Ticket: Change Catalyst registration to send pre-CIP36 message format in case the app is below version 6 |
vsubhuman
changed the title
vsubhuman
changed the title
Nebyt
previously approved these changes
Jul 18, 2023
vsubhuman
previously approved these changes
Jul 19, 2023
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When signing a catalyst registration tx, first check Ledger app version. If the version is 5, fallback to old CIP15 metadata format (but use payment address as reward address).