-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Desync issue #322
Merged
Merged
Fix Desync issue #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2019
vsubhuman
reviewed
Mar 10, 2019
SebastienGllmt
force-pushed
the
feature/desync
branch
from
March 11, 2019 15:59
1e5a19b
to
19faf46
Compare
vsubhuman
force-pushed
the
feature/desync
branch
from
March 13, 2019 23:50
a33e8f1
to
9067ecc
Compare
SebastienGllmt
force-pushed
the
feature/desync
branch
from
March 14, 2019 14:12
9067ecc
to
dc03779
Compare
vsubhuman
reviewed
Mar 15, 2019
* Due to desync issue caused by the incorrect bip44 implementation | ||
*/ | ||
reset(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
SebastienGllmt
force-pushed
the
feature/desync
branch
from
March 18, 2019 09:46
fa8a2e8
to
c597ccc
Compare
vsubhuman
reviewed
Mar 20, 2019
await syncAddresses(account, 'External'); | ||
|
||
await refreshChains(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
vsubhuman
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Premise
Solution
We use the same solution Yoroi-Mobile uses:
Migration system
Old wallets have two problems:
To fix this, I introduced a migration system. This is generic enough to help us perform migrations to new versions to maintain compatibility in the future also
To keep track of migrations, we now save
LAST-LAUNCH-VER
inlocalstorage
. That way whenever you launch the app, you know how many migration steps need to be applied to become compatible with the latest version.Since these steps may become long in the future, I exposed all the loading steps through the LoadingStore. This means in the future we can have a more fine-grained loading message (instead of just "loading..." we can say
Misc
I removed
generateSTxs.js
as it was used to stress-test the backend while Yoroi was still being developed and it's no longer used (and I didn't want to migrate the code to use the new bip44 setup)