Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm scope proposal #3093

Merged
merged 26 commits into from
Feb 2, 2023
Merged

wasm scope proposal #3093

merged 26 commits into from
Feb 2, 2023

Conversation

vsubhuman
Copy link
Contributor

No description provided.

@vsubhuman vsubhuman added this to the 4.19.0 milestone Jan 10, 2023
@vsubhuman vsubhuman requested review from yushih and neuodev January 10, 2023 18:34
@vsubhuman vsubhuman changed the title wasm mem handling wasm mem handling proposal Jan 10, 2023
@vsubhuman vsubhuman changed the title wasm mem handling proposal wasm scope proposal Jan 10, 2023
@neuodev
Copy link
Contributor

neuodev commented Jan 19, 2023

I was trying to write some unit testing

   // rustLoader.test.js
    it('Test...', () => {
        const addr = 'addr1qf2w3pe8jsyvr9kutpv6e0rzuaym7dvq0rrz9699a7y3wwvz6g3gz764vxla692p4ttcekdw0smpedxuqq7a8t8sv3usrcv98z';
        const fixedAddr = RustModule.WasmScope(Module => bytesToHex(
          Module.WalletV4.Address.from_bech32(addr).to_bytes()
        ));

        console.log(fixedAddr)
    })

But I got the Maximum call stack size exceeded from the recursive function!

@vsubhuman
Copy link
Contributor Author

vsubhuman commented Jan 22, 2023

But I got the Maximum call stack size exceeded from the recursive function!

@AhmedIbrahim336 , weird, call stack should not be happening. I have added some fixes, and also added a unit test now, plz check again: 6056e15

UPD: latest version of the test is here https://github.com/Emurgo/yoroi-frontend/blob/c9a6df5413a679b051fff42d8431e1d8de02c9bb/packages/yoroi-extension/app/api/ada/lib/cardanoCrypto/rustLoader.test.js

@neuodev
Copy link
Contributor

neuodev commented Jan 23, 2023

@AhmedIbrahim336 , weird, call stack should not be happening. I have added some fixes, and also added a unit test now, plz check again: 6056e15

Nice, I will check it!

Copy link
Contributor Author

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman merged commit ab5e5d0 into develop Feb 2, 2023
@vsubhuman vsubhuman deleted the ruslan/csl-mem branch February 2, 2023 15:36
@vsubhuman vsubhuman mentioned this pull request Feb 8, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants