Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date-range filters when exporting TX history #3055

Merged
merged 16 commits into from
Feb 2, 2023
Merged

Conversation

neuodev
Copy link
Contributor

@neuodev neuodev commented Nov 15, 2022

This feature is made under these assumptions

  1. Complete Tx history export is disabled
  2. Interval boundaries are included. E.g: [11-1-2022, 11-15-2022]
  3. If no TXs in the selected interval an error will be thrown so Yoroi doesn't export an empty file.
Preview Screen Shot 2022-11-17 at 10 51 12 AM

Todos

  • Flow & Lint

@neuodev neuodev marked this pull request as draft November 15, 2022 12:33
@neuodev neuodev marked this pull request as ready for review November 17, 2022 15:36
@neuodev neuodev requested review from yushih and vsubhuman November 17, 2022 15:36
Copy link
Contributor

@vsubhuman vsubhuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@vsubhuman vsubhuman merged commit 4cb8a0f into develop Feb 2, 2023
@vsubhuman vsubhuman deleted the Ahmed/date-range branch February 2, 2023 10:36
@vsubhuman vsubhuman mentioned this pull request Feb 8, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants