Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E tests for Sign Data and Get Collateral #2889

Merged
merged 13 commits into from
Jun 24, 2022
Merged

E2E tests for Sign Data and Get Collateral #2889

merged 13 commits into from
Jun 24, 2022

Conversation

cmerloglb
Copy link
Contributor

No description provided.

Base automatically changed from github-workflow-firefox to develop June 13, 2022 15:31
cmerloglb
cmerloglb commented Jun 14, 2022
View reviewed changes
Copy link
Contributor Author

@cmerloglb cmerloglb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

cmerloglb
cmerloglb commented Jun 14, 2022
View reviewed changes
Copy link
Contributor Author

@cmerloglb cmerloglb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

cmerloglb
cmerloglb commented Jun 14, 2022
View reviewed changes
Copy link
Contributor Author

@cmerloglb cmerloglb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

cmerloglb
cmerloglb commented Jun 14, 2022
View reviewed changes
Copy link
Contributor Author

@cmerloglb cmerloglb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@cmerloglb cmerloglb marked this pull request as ready for review June 14, 2022 18:44
@Nebyt Nebyt self-requested a review June 15, 2022 10:39
Nebyt
Nebyt requested changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent in slack all changes necessary to make

@cmerloglb cmerloglb marked this pull request as draft June 16, 2022 20:58
@cmerloglb cmerloglb changed the title Added functions to call signData api and 1 test E2E tests for Sign Data and Get Collateral Jun 22, 2022
cmerloglb
cmerloglb commented Jun 22, 2022
View reviewed changes
Copy link
Contributor Author

@cmerloglb cmerloglb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

cmerloglb
cmerloglb commented Jun 22, 2022
View reviewed changes
Copy link
Contributor Author

@cmerloglb cmerloglb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

cmerloglb
cmerloglb commented Jun 22, 2022
View reviewed changes
Copy link
Contributor Author

@cmerloglb cmerloglb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@cmerloglb cmerloglb marked this pull request as ready for review June 22, 2022 14:48
cmerloglb
cmerloglb commented Jun 22, 2022
View reviewed changes
Copy link
Contributor Author

@cmerloglb cmerloglb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

cmerloglb
cmerloglb commented Jun 24, 2022
View reviewed changes
Copy link
Contributor Author

@cmerloglb cmerloglb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

Nebyt
Nebyt reviewed Jun 24, 2022
View reviewed changes
Copy link
Contributor

@Nebyt Nebyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/check

@Nebyt Nebyt merged commit 94df623 into develop Jun 24, 2022
@Nebyt Nebyt deleted the e2e-signing-data branch June 24, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nebyt Nebyt Nebyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmerloglb @Nebyt