Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect server error in account state #1240

Merged
merged 4 commits into from
Dec 20, 2019
Merged

Conversation

SebastienGllmt
Copy link
Contributor

Due to instability of the node, sometimes the server is down or the account state endpoint returns the wrong result. To avoid users panicking, I try and detect these errors client-side and report an error in the UI

Notably

  1. Show an error message to the user instead of saying their ADA is not delegated
  2. Show the "total rewards" and "total delegated" as spinners instead of 0 ADA

image
image

@SebastienGllmt SebastienGllmt added the UI/UX Makes a visual change label Dec 20, 2019
@SebastienGllmt SebastienGllmt self-assigned this Dec 20, 2019
@SebastienGllmt SebastienGllmt merged commit f9e2d53 into shelley Dec 20, 2019
@SebastienGllmt SebastienGllmt deleted the delegation-mismatch branch December 20, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI/UX Makes a visual change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant