This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
fix packet_offset calculation, addin support for && and ; to python agent #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added in git ignore by mistake This reverts commit dd53b5e.
caleb-sfdcsec
changed the title
|
adds in support for use of && and ; in python agent also; example: |
This updates the ruby code to use fiddle library for ruby 2.3 and above while still supporting 'DL' for older versions. 'DL' is usually not found on new ruby installs. Additionally if any errors occur when it tries to run or while it's running, they will be logged to the keylog file instead of outputed to the terminal.
stderr + ruby fiddle support
|
Closing, we're going to make some changes and will resubmit. |
|
@caleb-sfdcsec Ok, thanks for the hard work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a bug in processing multiple commands that are stored in a packet.
The prior calculation does not include the length field in calculating the total size of the packet and so the offset is 4 bytes short.
This results in multiple commands across a single transmission failing to process properly and throwing a processTasking exception.
Solution: change packetOffset to start at 12, (2 for type + 2 for total + 2 for packet + 2 for task id + 4 for length = 12) + length value (for length of data)