PHPCS: Update to YoastCS 2.0.0 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See here about why the build is failing: #59 (comment) and here to see that the CS check does in actual fact pass: https://travis-ci.org/Yoast/comment-hacks/jobs/627424234#L801 |
This updates the dependency in `composer.json`, as well as the PHPCS ruleset for YoastCS 2.0.0.
Includes:
* A selective update of the `composer.lock` for just YoastCS and its dependencies.
* Removing the tweaks to the Composer `check-cs` script to allow for PHP >= 5.6.
PHP 5.6 is now the minimum PHP version everywhere.
Ref: https://github.com/Yoast/yoastcs/releases/tag/2.0.0
This deprecates the `yoast_comment_hacks_notification_roles` filter hook in favour of the `Yoast\WP\Comment\notification_roles` hook. [This needs a changelog entry]
This deprecates the `yoast_ch_admin_footer` action hook in favour of the `Yoast\WP\Comment\admin_footer` hook. [This needs a changelog entry]
This deprecates the `yoast_comment_redirect` filter hook in favour of the `Yoast\WP\Comment\redirect` hook. [This needs a changelog entry]
jrfnl
force-pushed
the
JRF/upgrade-to-yoastcs-2.0
branch
from
8dceffc to
bedb221
Compare
|
CR & Acceptance: 👍 |
karlijnbok
added
the
changelog: non-user-facing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPCS: Update to YoastCS 2.0.0
This updates the dependency in
composer.json, as well as the PHPCS ruleset for YoastCS 2.0.0.Includes:
composer.lockfor just YoastCS and its dependencies.check-csscript to allow for PHP >= 5.6.PHP 5.6 is now the minimum PHP version everywhere.
Ref: https://github.com/Yoast/yoastcs/releases/tag/2.0.0
CS: deprecate old-style hook and add new-style hook [1]
This deprecates the
yoast_comment_hacks_notification_rolesfilter hook in favour of theYoast\WP\Comment\notification_roleshook.[This needs a changelog entry]
CS: deprecate old-style hook and add new-style hook [2]
This deprecates the
yoast_ch_admin_footeraction hook in favour of theYoast\WP\Comment\admin_footerhook.[This needs a changelog entry]
CS: deprecate old-style hook and add new-style hook [3]
This deprecates the
yoast_comment_redirectfilter hook in favour of theYoast\WP\Comment\redirecthook.[This needs a changelog entry]
CS: use short arrays (everywhere)
Testing
See the test instructions in the Yoast/wpseo-woocommerce#451 PR for guidance on how to test this PR.