-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various tweaks #118
Various tweaks #118
Conversation
$roles = \apply_filters( 'EmiliaProjects\WP\Comment\notification_roles', $roles ); | ||
$roles = \apply_filters( | ||
'EmiliaProjects\WP\Comment\notification_roles', | ||
[ 'contributor', 'author', 'editor', 'administrator', 'super-admin' ] | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$roles
was undefined here. The doc for this filter was saying "Defaults to contributor and up", so the array used here contains these roles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of remarks above.
I also think we should update composer.json
to be all Emilia not joost.blog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments.
I changed the |
WordPress PlaygroundYou can easily test this pull request on the WordPress Playground. |
Context
This PR contains various tweaks and improvements:
grunt
task. Our CSS & JS files are so small and basic that we don't need build processes, minification etc.yst
prefix withepch
(Emilia Projects Comment Hacks)Relevant technical choices:
Test instructions
Relevant test scenarios
UI changes
Documentation
Quality assurance
Fixes #