-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup - prep for new plugin #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdevalk
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just think we can make it even easier on ourselves. We should probably also just update the namespace to something simpler, although there may be reasons to include the company name?
jdevalk
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Preliminary work for the new plugin which will be released with a
comment-hacks
slugyoast-comment-hacks
tocomment-hacks
Emilia-Capital
umbrellayoast_
andyoast-
prefixes withemiliaprojects_
andemiliaprojects-
yoast-comment-hacks
tocomment-hacks
emiliaProjects
prefix instead ofyoast
yoast
prefixTest instructions
Test that the main plugin functionality and admin UIs still works as expected. A lot of stuff was renamed, classes, IDs etc, so we should make sure things are still in the right place.
NOTE: Since the main plugin file was renamed, if the previous version is activated, it should be deactivated prior to pulling this PR. This should not be treated as an update, but as a new plugin.
Relevant test scenarios
UI changes
NOTE: The UI itself didn't change, however the HTML of the UI did.
Documentation
Quality assurance
Fixes #