Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup - prep for new plugin #117

Merged
merged 19 commits into from
Jan 22, 2024
Merged

Cleanup - prep for new plugin #117

merged 19 commits into from
Jan 22, 2024

Conversation

aristath
Copy link
Member

@aristath aristath commented Jan 22, 2024

Context

Preliminary work for the new plugin which will be released with a comment-hacks slug

  • Remove references and links to Yoast
  • Rename the plugin from yoast-comment-hacks to comment-hacks
  • Change repo URLs to point to the new URL under the Emilia-Capital umbrella
  • Replace the yoast_ and yoast- prefixes with emiliaprojects_ and emiliaprojects-
  • Remove deprecated code. Since this will be a new plugin, deprecated code should not be kept
  • Change the textdomain from yoast-comment-hacks to comment-hacks
  • Rename global JS functions to use the emiliaProjects prefix instead of yoast
  • Remove global variables containing the yoast prefix
  • Clean-up the changelog.

Test instructions

Test that the main plugin functionality and admin UIs still works as expected. A lot of stuff was renamed, classes, IDs etc, so we should make sure things are still in the right place.
NOTE: Since the main plugin file was renamed, if the previous version is activated, it should be deactivated prior to pulling this PR. This should not be treated as an update, but as a new plugin.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Block/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.
    NOTE: The UI itself didn't change, however the HTML of the UI did.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities.
  • I have added unit tests to verify the code works as intended.
  • I have checked that the base branch is correctly set.

Fixes #

@aristath aristath changed the base branch from trunk to develop January 22, 2024 12:12
@aristath aristath changed the title 🚧 WIP: Cleanup Cleanup - prep for new plugin Jan 22, 2024
@aristath aristath marked this pull request as ready for review January 22, 2024 12:12
@aristath aristath requested a review from jdevalk January 22, 2024 12:13
@aristath aristath mentioned this pull request Jan 22, 2024
9 tasks
Copy link
Member

@jdevalk jdevalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just think we can make it even easier on ourselves. We should probably also just update the namespace to something simpler, although there may be reasons to include the company name?

.phpcs.xml.dist Outdated Show resolved Hide resolved
.phpcs.xml.dist Outdated Show resolved Hide resolved
.wordpress-org/icon.svg Outdated Show resolved Hide resolved
Security.md Show resolved Hide resolved
admin/admin.php Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
readme.txt Show resolved Hide resolved
@jdevalk jdevalk merged commit d5eae6e into develop Jan 22, 2024
13 checks passed
@jdevalk jdevalk deleted the cleanup branch January 22, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants