Bugfix check hash value on page load (#86)

EmicoEcommerce · Aug 23, 2023 · 55388e7 · 55388e7
1 parent 67adf95
commit 55388e7
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/Model/Client/Type/SuggestionType/SuggestionTypeCategory.php b/Model/Client/Type/SuggestionType/SuggestionTypeCategory.php
@@ -31,6 +31,11 @@ class SuggestionTypeCategory extends SuggestionTypeAbstract
      */
     protected $urlInstance;
 
+    /**
+     * @var Config
+     */
+    protected $config;
+
     /**
      * SuggestionTypeCategory constructor.
      * @param CategoryRepository $categoryRepository Empty category model used to resolve urls

diff --git a/Model/FilterFormInputProvider/HashInputProvider.php b/Model/FilterFormInputProvider/HashInputProvider.php
@@ -61,6 +61,11 @@ public function validateHash($request)
             if ($hash === $originalHash) {
                 $isValid = true;
             }
+        } else {
+            //hash is empty original url should also be empty
+            if (empty ($request->getParam('__tw_original_url'))) {
+                $isValid = true;
+            }
         }
 
         return $isValid;

diff --git a/Model/NavigationConfig.php b/Model/NavigationConfig.php
@@ -10,6 +10,7 @@
 use Magento\Framework\UrlInterface;
 use Magento\Framework\Serialize\Serializer\Json;
 use Magento\Framework\View\Element\Block\ArgumentInterface;
+use Tweakwise\Magento2Tweakwise\Model\FilterFormInputProvider\HashInputProvider;
 
 /**
  * Class NavigationConfig
@@ -57,6 +58,11 @@ class NavigationConfig implements ArgumentInterface, FilterFormInputProviderInte
      */
     protected $request;
 
+    /**
+     * @var HashInputProvider
+     */
+    protected $hashInputProvider;
+
     /**
      * NavigationConfig constructor.
      * @param Config $config
@@ -74,7 +80,8 @@ public function __construct(
         ProductMetadataInterface $productMetadata,
         FilterFormInputProviderInterface $filterFormInputProvider,
         Json $jsonSerializer,
-        Http $request
+        Http $request,
+        HashInputProvider $hashInputProvider
     ) {
         $this->config = $config;
         $this->jsonSerializer = $jsonSerializer;
@@ -83,13 +90,20 @@ public function __construct(
         $this->productMetadata = $productMetadata;
         $this->filterFormInputProvider = $filterFormInputProvider;
         $this->request = $request;
+        $this->hashInputProvider = $hashInputProvider;
     }
 
     /**
      * @inheritDoc
      */
     public function getFilterFormInput(): array
     {
+        //check request for modified values
+        if (!$this->hashInputProvider->validateHash($this->request)) {
+            //form is modified, don't accept the request. Should only happen in an xss attack
+            throw new \InvalidArgumentException('Incorrect/modified form parameters');
+        }
+
         $filterFormInput = $this->filterFormInputProvider->getFilterFormInput();
         unset($filterFormInput['p']);