Skip to content
This repository has been archived by the owner on Oct 19, 2022. It is now read-only.

Commit

Permalink
Disable Reflected XSS on de slider confguration
Browse files Browse the repository at this point in the history
The Slider configuration contains the current url, which could be escaped adding a single quote `'`.

This way it was possible to add reflected XSS in the URL
For obvious reasons I will not add the URL's used here.
  • Loading branch information
JeroenBoersma authored Jan 4, 2022
1 parent 79a3401 commit 2fd9caa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion view/frontend/templates/product/layered/slider.phtml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ $disabledSliderUrlInputValue = sprintf('%s-%s', $minValue, $maxValue);
<span class="postfix"><?= $itemPostfix ?></span>
</span>
</div>
<div class="slider" data-mage-init='<?=$block->getJsSliderConfig()?>'></div>
<div class="slider" data-mage-init="<?=$block->escapeHtmlAttr($block->getJsSliderConfig())?>"></div>
<div class="labels">
<span class="current-min-value">
<span class="prefix"><?= $itemPrefix ?></span>
Expand Down

0 comments on commit 2fd9caa

Please sign in to comment.