Made a more clear fallback for featured products if api fails.

EmicoEcommerce · Oct 21, 2017 · 132af7d · 132af7d
1 parent 73ae09b
commit 132af7d
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 4 deletions.
diff --git a/src/Block/Catalog/Product/ProductList/Featured.php b/src/Block/Catalog/Product/ProductList/Featured.php
@@ -8,6 +8,7 @@
 
 namespace Emico\Tweakwise\Block\Catalog\Product\ProductList;
 
+use Emico\Tweakwise\Exception\ApiException;
 use Emico\Tweakwise\Model\Catalog\Product\Recommendation\Collection;
 use Emico\Tweakwise\Model\Catalog\Product\Recommendation\Context as RecommendationsContext;
 use Emico\Tweakwise\Model\Client\Request\Recommendations\FeaturedRequest;
@@ -103,6 +104,20 @@ private function configureRequest(FeaturedRequest $request)
         $request->setTemplate($templateId);
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    protected function _beforeToHtml()
+    {
+        try {
+            $this->_getProductCollection();
+        } catch (ApiException $e) {
+            return;
+        }
+
+        return parent::_beforeToHtml();
+    }
+
     /**
      * {@inheritdoc}
      */
@@ -111,6 +126,13 @@ protected function _toHtml()
         if (!$this->config->isRecommendationsEnabled(Config::RECOMMENDATION_TYPE_FEATURED)) {
             return '';
         }
+
+        try {
+            $this->_getProductCollection();
+        } catch (ApiException $e) {
+            return '';
+        }
+
         return parent::_toHtml();
     }
 }
diff --git a/src/Block/TargetRule/Catalog/Product/ProductList/Plugin.php b/src/Block/TargetRule/Catalog/Product/ProductList/Plugin.php
@@ -9,6 +9,7 @@
 namespace Emico\Tweakwise\Block\TargetRule\Catalog\Product\ProductList;
 
 use Closure;
+use Emico\Tweakwise\Exception\ApiException;
 use Emico\Tweakwise\Exception\InvalidArgumentException;
 use Emico\Tweakwise\Model\Catalog\Product\Recommendation\Collection;
 use Emico\Tweakwise\Model\Catalog\Product\Recommendation\Context;
@@ -81,7 +82,11 @@ public function aroundGetItemCollection(AbstractProductList $subject, Closure $p
             return $proceed();
         }
 
-        return $this->getCollection()->getItems();
+        try {
+            return $this->getCollection()->getItems();
+        } catch (ApiException $e) {
+            return $proceed();
+        }
     }
 
     /**
@@ -95,7 +100,11 @@ public function aroundGetPositionLimit(AbstractProductList $subject, Closure $pr
             return $proceed();
         }
 
-        return $this->getCollection()->count();
+        try {
+            return $this->getCollection()->count();
+        } catch (ApiException $e) {
+            return $proceed();
+        }
     }
 
     /**

diff --git a/src/Model/Client/Response/RecommendationsResponse.php b/src/Model/Client/Response/RecommendationsResponse.php
@@ -15,11 +15,21 @@
  * Class RecommendationsResponse
  *
  * @package Emico\Tweakwise\Model\Client\Response
- *
- * @method ItemType[] getItems();
  */
 class RecommendationsResponse extends Response
 {
+    /**
+     * @return ItemType[]
+     */
+    public function getItems()
+    {
+        $data = $this->getDataValue('items');
+        if (!$data) {
+            return [];
+        }
+        return $data;
+    }
+
     /**
      * @param ItemType[]|array[] $items
      * @return $this