add testv cov action #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prathyusha/code_cov_action
sahith-narahari
suggested changes
Mar 9, 2022
| - name: Setup multisdk | ||
| run: make setup-${{ matrix.versions }} | ||
|
|
||
| - name: golangci-lint |
There was a problem hiding this comment.
the lint seems to be failing, also make target for lint is missing
There was a problem hiding this comment.
yeah, Lint is failing bcz of some unused code.
Error: transferMsgType is unused in v42/v44. So shall I remove/comment it.
There was a problem hiding this comment.
Are you sure it's not being used in either of the versions, it gets tricky in this repo with build flags.
There was a problem hiding this comment.
The code which has used it was commented, but not transferMsgType var.
|
@PrathyushaLakkireddy can you please add a make target for running lint locally |
PrathyushaLakkireddy
requested review from
0xmuralik
and removed request for
gsora
0xmuralik
approved these changes
Apr 5, 2022
akhilkumarpilli
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.