remove gaia dependency #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukitsbrian
requested review from
sgerogia,
Pitasi,
akhilkumarpilli,
0xmuralik,
DeshErBojhaa,
PrathyushaLakkireddy and
a team
Pitasi
approved these changes
May 2, 2022
There was a problem hiding this comment.
utack (we can revert is something foes wrong)
also I consider this utils module an anti pattern since we share a single "utils" module that mixes too much logic from different concepts (db, redis, sdk stuff) and we lose track of what's used and what's not. So everything that can be moved out of this package looks good to me 😛
If we want to maintain a single utile repo maybe we can have multiple go.mods for the different areas, we'll need to think about the implications of doing so though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we ever use
store.Cdcanywhere?Removing
gaia.MakeCodecswill allow us to use newer versions of the cosmos sdk wherever utils are imported.