add correlation ids

[PrathyushaLakkireddy]

Fixes EmerisHQ/demeris-backend#346

[sgerogia]

If you have not seen it, @gsora has left a relevant comment in the issue.

Please replace the existing generated error id to be the int_correlation_id

[0xmuralik]

If you have not seen it, @gsora has left a relevant comment in the issue.

Please replace the existing generated error id to be the int_correlation_id

Yup! Added that in the Deps.WriteError function here.

[sgerogia]

@SpideyPool192 I do not think that this merge automatically created a release
Can you create a minor release of emeris-utils and update the code here?

This needs to be reviewed and merged today if possible

[DeshErBojhaa]

Hi, can you write in short why you're panicking in the router instead of writing the error to log (even to the response maybe).

Also please shortly explain the logic behind the panic in deps.go

[Pitasi]

is this safe to do? When multiple API calls arrive aren't them executed concurrently and sharing the same router object?

even it this was safe looks like an anti-pattern to me: request-related stuff should stay inside request's context. What's this r.l used for anyway?

[0xmuralik]

We set a modified logger to the context in the CorrelationIDMiddleware function. Intention is to use this logger everywhere. As the api server uses the logger from router, I'm changing the router logger (r.l) to use the logger from context.

[Pitasi]

We set a modified logger to the context in the CorrelationIDMiddleware function. Intention is to use this logger everywhere.

that's ok

As the api server uses the logger from router, I'm changing the router logger (r.l) to use the logger from context.

I don't get why we need a router logger (+ I'm still concerned about concurrency safety)

[0xmuralik]

cc @gsora @sahith-narahari

[0xmuralik]

Hi, can you write in short why you're panicking in the router instead of writing the error to log (even to the response maybe).

Also please shortly explain the logic behind the panic in deps.go

Hi, can you write in short why you're panicking in the router instead of writing the error to log (even to the response maybe).

Also please shortly explain the logic behind the panic in deps.go

The issue suggests that we use a logger from the context if it doesn't exist check if there is another logger (to the router) provided. If there is no logger found we panic.

In deps.go we are trying to replace the error id with the internal correlation id which we created earlier. Hence, we try to find it in the context and panic if not found.

[DeshErBojhaa]

LGTM!