New endoint /accounts/raw_address #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbruyelle
requested review from
akc2267,
CommoDor64 and
lukitsbrian
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most requested data by the front are
balances,delegationsandunbonding_delegations:That represents the majority of the requests, because for each chain (for each chain bech32 address), a request is executed.
@Pitasi suggested this could be consolidated by changing the endpoints to they take a list of address instead of a single one.
Actually we can also go further by using the keplr raw address from
(await keplr.getKey('comoshub')).address. From this address we can easily derive the bech32 chain addresses in the backend, and return everything within a single endpoint :Note that
(await keplr.getKey('comoshub')).addressmust be hex encoded before passing it the URL.This should significantly reduce the number of requests, without performance issue since the new endpoint fetches the data concurrently.
Note: This PR has a lot of changes because I also refactored the related endpoints with the usecase pattern, with tons of tests.