-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support in recurring group name in files. #45
Conversation
Thanks for the merge request! In general i think this is a feasible workaround. the only thing I am thinking about is, if it would make sense to change the naming schema for the duplicated groupnames. Maybe {groupname}_{group_id}? How does the groupid usually look like? |
@MattiasFredriksson does this interfere with #43 in any way? |
@AKuederle AKuederle There should be a conflict but there are no functional differences (the KeyError message was updated to be more descriptive). Otherwise I'm wondering if the name update should be done in this fashion since this is a public method. Not throwing KeyErrors when external code adds a Group could cause silent errors/bugs as it would allow duplicates to be created 'unintentionally'. However, resolving such issues could be done in the future as it would probably complicate the solution a bit. The standard string formatting currently used is on the form: |
I agree! My suggestion would be to hide the overwrite behind a parameter that is False by default |
Co-authored-by: Charlie Hewitt <[email protected]>
I made the changes I suggested above:
@friggog What do you think? |
@yochaytz Thanks again for the contribuition! I will try to make a new release later today containing this fix. And @friggog and @MattiasFredriksson thanks for the reviews and the input! |
No description provided.