Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poetry #40

Merged
merged 11 commits into from
Jan 23, 2022
Merged

Poetry #40

merged 11 commits into from
Jan 23, 2022

Conversation

AKuederle
Copy link
Collaborator

Switched tooling to poetry.

For that a couple of additional changes were required:

  • Move c3d to a package subfolder
  • Refactor the scripts so that they have a main without arguments

I also added github workflows to run tests on commit and publish on release (Note: I haven't yet configured the project secrets, so the latter will not work yet)

@AKuederle AKuederle requested a review from friggog January 21, 2022 16:09
friggog
friggog approved these changes Jan 21, 2022
View reviewed changes
Copy link
Collaborator

@friggog friggog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Base automatically changed from test_fix to master January 23, 2022 10:06
@AKuederle AKuederle merged commit 353b7ed into master Jan 23, 2022
@AKuederle AKuederle deleted the poetry branch January 23, 2022 10:06
@AKuederle AKuederle mentioned this pull request Jan 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friggog friggog friggog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AKuederle @friggog