hm #148
Annotations
10 errors and 2 warnings
app/controllers/api/v1/timelines/public_controller.rb#L17
[Correctable] Style/NegatedIfElseCondition: Invert the negated condition and swap the if-else branches.
|
app/controllers/api/v1/timelines/public_controller.rb#L29
[Correctable] Style/GuardClause: Use a guard clause (return unless Setting.timeline_preview_local && truthy_param?(:local)) instead of wrapping the code inside a conditional expression. (https://rubystyle.guide#no-nested-conditionals)
|
app/controllers/api/v1/timelines/public_controller.rb#L29
[Correctable] Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://rubystyle.guide#if-as-a-modifier)
|
app/controllers/api/v1/timelines/public_controller.rb#L30
[Correctable] Style/RedundantReturn: Redundant return detected. (https://rubystyle.guide#no-explicit-return)
|
app/controllers/api/v1/timelines/public_controller.rb#L35
[Correctable] Style/GuardClause: Use a guard clause (return unless Setting.timeline_preview_remote && truthy_param?(:remote)) instead of wrapping the code inside a conditional expression. (https://rubystyle.guide#no-nested-conditionals)
|
app/controllers/api/v1/timelines/public_controller.rb#L35
[Correctable] Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||. (https://rubystyle.guide#if-as-a-modifier)
|
app/controllers/api/v1/timelines/public_controller.rb#L36
[Correctable] Style/RedundantReturn: Redundant return detected. (https://rubystyle.guide#no-explicit-return)
|
app/helpers/admin/trends/statuses_helper.rb#L17
[Correctable] Layout/TrailingWhitespace: Trailing whitespace detected. (https://rubystyle.guide#no-trailing-whitespace)
|
app/helpers/context_helper.rb#L48
[Correctable] Style/MapIntoArray: Use map instead of each to map elements into an array. (https://rubystyle.guide#functional-code)
|
app/models/concerns/account/interactions.rb#L234
[Correctable] Rails/WhereExists: Prefer exists?(account: self, name: name, custom_emoji: custom_emoji) over where(account: self, name: name, custom_emoji: custom_emoji).exists?.
|
app/helpers/admin/trends/statuses_helper.rb#L3
[Correctable] Lint/DuplicateMagicComment: Duplicate magic comment detected.
|
app/models/concerns/account/interactions.rb#L237
Lint/DuplicateMethods: Method Account::Interactions#reacted? is defined at both app/models/concerns/account/interactions.rb:233 and app/models/concerns/account/interactions.rb:237.
|
This job failed
Loading