Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSUrlConnection wrapper returns "Bad Request" NSData instead of NSError #12

Open
dodikk opened this issue Apr 9, 2013 · 1 comment
Open
Assignees

Comments

@dodikk
Copy link
Member

dodikk commented Apr 9, 2013

Steps :
Attempt to download a file from the URL that returns "HTTP 400" error.

Actual result : "Bad request" string is returned in plain text
Expected result : A valid JHttpError is returned.


JFFAsyncOperation genericDataURLResponseLoader(JFFURLConnectionParams *params)
{
   return privateGenericDataURLResponseLoader(params, nil);
}

dataURLResponseLoader() implementation is missing the downloadErrorFlagResponseAnalyzer() predicate (nil is used as a stub). Adding the mentioned predicate solves the issue but some backward compatibility checks (code review) are required.

dodikk added a commit that referenced this issue Apr 9, 2013
@dodikk
Copy link
Member Author

dodikk commented Apr 9, 2013

Fixed in 33bd75d

@ghost ghost assigned volodg Apr 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants