Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

construct the USB CDC transport, rather than a client #220

Merged

Conversation

yanyang517
Copy link
Contributor

It shall construct a USB CDC transport here. Otherwise, it fails to build.
Please help to review it.

@MichalPrincNXP MichalPrincNXP self-requested a review December 14, 2021 12:16
@MichalPrincNXP MichalPrincNXP self-assigned this Dec 14, 2021
Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @yanyang517 , yes, you are right, this has been incorrectly changed in #169
Because the next release is going to be released soon, the testing almost finished and because of our internal process, I am postponing this PR integration for some weeks, ok?
Thank you for noticing that and preparing this PR.

@yanyang517
Copy link
Contributor Author

It's ok for me. Thanks for your response.

@Hadatko Hadatko added this to the 1.8.2 milestone Jan 2, 2022
@Hadatko
Copy link
Member

Hadatko commented Jan 2, 2022

Copy paste issue. Sorry for that.

@Hadatko Hadatko modified the milestones: 1.8.3, 1.8.2 Jan 11, 2022
@MichalPrincNXP MichalPrincNXP modified the milestones: 1.9.0, 1.9.1 Jan 18, 2022
@MichalPrincNXP MichalPrincNXP merged commit 50b55bd into EmbeddedRPC:develop Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants