Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image-pull-secret option #54

Merged
merged 14 commits into from
Feb 9, 2023
Merged

Add image-pull-secret option #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2cc7070
test without args
clbx Dec 5, 2022
7c332f1
add back in arguments
clbx Dec 5, 2022
cebbba7
add image pull secret
clbx Jan 5, 2023
809385d
pull secret test
clbx Jan 5, 2023
4c6a1d9
testing pull secrets
clbx Jan 5, 2023
426ec50
remove hardcode
clbx Jan 5, 2023
bececd3
remove the line if there are none
clbx Jan 5, 2023
98e120e
fix json
clbx Jan 5, 2023
5bb00bf
print manifest
clbx Jan 5, 2023
96b3927
typo?
clbx Jan 5, 2023
3092f1f
put back
clbx Jan 5, 2023
c07776e
jsonnet changes
clbx Jan 5, 2023
e0efa20
remove double array
clbx Jan 5, 2023
48c87db
Add docs, put script back
clbx Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,11 @@ Whether to always pull the latest image before running the command. Sets [imageP

Default: `false`

### ``image-pull-secret`` (optional, string)

The name of the secret that holds the credentials for a remote container registry.


### `command` (optional, array)

Sets the command for the container. Useful if the container image has an entrypoint, but requires extra arguments.
Expand Down
9 changes: 9 additions & 0 deletions lib/job.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ function(jobName, agentEnv={}, stepEnvFile='', patchFunc=identity) patchFunc({
BUILDKITE_PLUGIN_K8S_AGENT_TOKEN_SECRET_KEY: 'buildkite-agent-token',
BUILDKITE_PLUGIN_K8S_INIT_IMAGE: 'embarkstudios/k8s-buildkite-agent@sha256:3c010d09915f3b39c2f8324af5f0aaf910a643e7d63607ee8d49653931b8b167',
BUILDKITE_PLUGIN_K8S_ALWAYS_PULL: false,
BUILDKITE_PLUGIN_K8S_IMAGE_PULL_SECRET: '',
BUILDKITE_PLUGIN_K8S_BUILD_PATH_HOST_PATH: '',
BUILDKITE_PLUGIN_K8S_BUILD_PATH_PVC: '',
BUILDKITE_PLUGIN_K8S_GIT_MIRRORS_HOST_PATH: '',
Expand Down Expand Up @@ -273,6 +274,12 @@ function(jobName, agentEnv={}, stepEnvFile='', patchFunc=identity) patchFunc({

local deadline = std.parseInt(env.BUILDKITE_TIMEOUT) * 60,

local imagePullSecrets =
if env.BUILDKITE_PLUGIN_K8S_IMAGE_PULL_SECRET == '' then []
else [
{name: env.BUILDKITE_PLUGIN_K8S_IMAGE_PULL_SECRET},
],

apiVersion: 'batch/v1',
kind: 'Job',
metadata: {
Expand All @@ -297,6 +304,8 @@ function(jobName, agentEnv={}, stepEnvFile='', patchFunc=identity) patchFunc({
restartPolicy: 'Never',
serviceAccountName: env.BUILDKITE_PLUGIN_K8S_SERVICE_ACCOUNT_NAME,
initContainers: initContainers,
imagePullSecrets: imagePullSecrets,

containers: [
{
name: 'step',
Expand Down
2 changes: 2 additions & 0 deletions plugin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ configuration:
properties:
image:
type: string
image-pull-secret:
type: string
always-pull:
type: boolean
command:
Expand Down