ci: Check minimal version of dependencies #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspermeijn
force-pushed
the
ci_minimal_versions
branch
from
f320efd
to
1e6f617
Compare
This crate fails to build with version 0.12.11. So the minimal version should be 0.12.15.
3 tasks
Check that the minimal dependency versions specified in `Cargo.toml` successfully builds. `cargo minimal-versions check` will downgrade all dependencies and then run `cargo check`.
caspermeijn
force-pushed
the
ci_minimal_versions
branch
from
1e6f617
to
3e00e6e
Compare
caspermeijn
changed the title
|
I'm not really interested in adding CI complexity for an unstable cargo feature, this crate is only updated on a 6-week cadence, it's not a burden to just manually bump the patch version of target-lexicon to whatever is tested in CI. |
|
I understand your decision. I suggested the CI job as a reminder to not forget that manual work 😉 For your information, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Check that the minimal dependency versions specified in
Cargo.tomlsuccessfully builds.cargo minimal-versions checkwill downgrade all dependencies and then runcargo check.Related Issues
This branch also contains #72. I suggest to first merging that and to rebase this PR.