Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allow list for dependencies that have build scripts #432

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Add allow list for dependencies that have build scripts #432

merged 5 commits into from
Jun 29, 2022

Conversation

Stupremee
Copy link
Contributor

Resolves #19

Jake-Shadle
Jake-Shadle requested changes Jun 22, 2022
View reviewed changes
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a few minor notes.

src/bans.rs Outdated Show resolved Hide resolved
src/bans.rs Outdated Show resolved Hide resolved
@Jake-Shadle
Remove cfg contents from diagnostic
08a4802 
In large projects this could be very large and would bloat output with
little benefit.
Jake-Shadle
Jake-Shadle approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 824c2d1 into EmbarkStudios:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jake-Shadle Jake-Shadle Jake-Shadle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add allow list for crates with build.rs
2 participants
@Stupremee @Jake-Shadle