Remove fix functionality
#423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality was only added when there was the potential for cargo-deny to supplant cargo-audit, which is no longer the case. This functionality was quite a lot of code, minimally tested and increased compile times (toml_edit), all for a feature that, at least anecdotally, is not really useful as any moderately complex dependency graph is unlikely to be patchable.
|
always nice to see dead code being trimmed. 🚀 Where can I read up on the "potential for cargo-deny to supplant cargo-audit, which is no longer the case." bit if you don't mind my asking? |
|
#194 was the original issue. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
cargo-deny fixfunctionality was only added when there was the potential for cargo-deny to supplant cargo-audit, which is no longer the case. This functionality was quite a lot of code, minimally tested, and increased compile times (mostly because of toml_edit which is super slow to compile for some reason), all for a feature that, at least anecdotally, is not really useful, as any moderately complex dependency graph is unlikely to be patchable to fix an advisory, as the advisory either has no available fix, or if it does, 1 or more dependencies are stuck on an old version and requires supplying PRs and publishing new releases anyways. It's just not worth it to be honest.