-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling logging causes summary to be incorrect #652
Labels
bug
Something isn't working
Comments
matthiasbeyer
added a commit
to matthiasbeyer/actions-to-website
that referenced
this issue
Apr 18, 2024
Because of EmbarkStudios/cargo-deny#652 This reverts commit f6825cc.
Oh nvm I see what you are saying, disabling logging means the final summary loses all information. |
Jake-Shadle
changed the title
Bug: Disable logging lets errors vanish
Disabling logging causes summary to be incorrect
Apr 24, 2024
Jake-Shadle
added a commit
that referenced
this issue
Apr 24, 2024
Disabling logging would cause both the stats at the end, but more crucially, the exit code (if errors occurred), to be incorrect. Resolves: #652
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
And:
To reproduce
cargo-deny version
cargo-deny 0.14.21
What OS were you running cargo-deny on?
Linux
Additional context
No response
The text was updated successfully, but these errors were encountered: