Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not specifying db-path in configuration template #612

Closed
LucasFA opened this issue Feb 23, 2024 · 0 comments · Fixed by #613
Closed

Consider not specifying db-path in configuration template #612

LucasFA opened this issue Feb 23, 2024 · 0 comments · Fixed by #613
Labels
enhancement New feature or request

Comments

@LucasFA
Copy link

LucasFA commented Feb 23, 2024

Is your feature request related to a problem? Please describe.
I have a custom path for CARGO_HOME. Running cargo deny init defaults to including in the configuration the path to the database ~/.cargo/advisory-db. In my case, that creates an unnecessary ~/.cargo folder in my HOME directory.

Describe the solution you'd like
I tested just commenting out the offending line and it seemed to default to my CARGO_HOME, exactly as I want.

Describe alternatives you've considered

  • Relying on the existence of the CARGO_HOME environment variable at the time of cargo deny init would probably lead to stale configuration, as now.
  • Documenting this fact in the README probably helps warn some - probably not all - users, but seems unnecessary to add to the length of text.

Additional context
Somewhat related: #302. This change would bring the default (aka, without deny.toml) behaviour to the deny.toml default template.

@LucasFA LucasFA added the enhancement New feature or request label Feb 23, 2024
Jake-Shadle added a commit that referenced this issue Feb 23, 2024
`~` has been supported for a while, but this PR expands support to
include bash-style environment variable expansion (to a limited degree).

Resolves: #612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant