Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exporter on non-windows operating systems #5

Merged
merged 1 commit into from
May 20, 2020

Conversation

drewcassidy
Copy link
Contributor

The root directory path is hardcoded to a backslash currently, which breaks support on non-windows operating systems. This replaces that with a forward slash, which should work on all operating systems. see #4.

@drewcassidy
Copy link
Contributor Author

I'm honestly not sure why this failed in the linter since the only line I changed didnt create a warning in the output log

@moppius
Copy link
Member

moppius commented May 20, 2020

I'm honestly not sure why this failed in the linter since the only line I changed didnt create a warning in the output log

Looks like there's a config problem with the linter, sorry about that - I will investigate!

Good catch, and thanks for the PR. We hadn't tested the addon on Linux or MacOS yet, so thanks for taking care of this!

@moppius
Copy link
Member

moppius commented May 20, 2020

So apparently this is a bug introduced in PyLint 2.5.1...
Also mentioned in a different bug here - looks like they don't properly respect relative imports, and they aiming to fix it for PyLint 2.5.4!

I'll pin PyLint to an older release for now and re-run the checks.

@moppius moppius self-assigned this May 20, 2020
@moppius
Copy link
Member

moppius commented May 20, 2020

If you merge latest master in to this branch now, linting should pass!

I'm considering maybe removing the RELATIVE_ROOT thing entirely, though, and instead requiring that the user defines a valid path by browsing to it, and we'd disable all UI until they had done that.

Out of interest, when the Project Source Path is set to ./, what would you expect the behaviour to be?

As a studio, we always want the stored paths to be relative to an absolute location that might differ from machine to machine, which is what the Project Source Path represents.

Right now it seems like it can actually output exported collections into the Blender install location when set to ./, which seems like a bug.

@drewcassidy
Copy link
Contributor Author

if it's set to ./ I'd expect it to place files relative to the filesystem root

Copy link
Member

@moppius moppius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let us know if anything else breaks on MacOS, most of us at Embark don't use that as a primary development platform with Blender, so there may be other issues we haven't run into.

@moppius moppius merged commit 990a4b9 into EmbarkStudios:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants