-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exporter on non-windows operating systems #5
Conversation
I'm honestly not sure why this failed in the linter since the only line I changed didnt create a warning in the output log |
Looks like there's a config problem with the linter, sorry about that - I will investigate! Good catch, and thanks for the PR. We hadn't tested the addon on Linux or MacOS yet, so thanks for taking care of this! |
So apparently this is a bug introduced in PyLint 2.5.1... I'll pin PyLint to an older release for now and re-run the checks. |
If you merge latest I'm considering maybe removing the Out of interest, when the Project Source Path is set to As a studio, we always want the stored paths to be relative to an absolute location that might differ from machine to machine, which is what the Project Source Path represents. Right now it seems like it can actually output exported collections into the Blender install location when set to |
if it's set to ./ I'd expect it to place files relative to the filesystem root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let us know if anything else breaks on MacOS, most of us at Embark don't use that as a primary development platform with Blender, so there may be other issues we haven't run into.
The root directory path is hardcoded to a backslash currently, which breaks support on non-windows operating systems. This replaces that with a forward slash, which should work on all operating systems. see #4.