Fix reference cycle in example, remove unnecessary weak / strong (AFN…

…etworking#4196) * Fixed memory leak issues * Fixed memory leak issues * Fixed crash
ElfSundae · Jan 5, 2020 · 0fba527 · 0fba527
1 parent 4743faa
commit 0fba527
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/AFNetworking/AFURLSessionManager.m b/AFNetworking/AFURLSessionManager.m
@@ -531,20 +531,17 @@ - (instancetype)initWithSessionConfiguration:(NSURLSessionConfiguration *)config
     self.lock = [[NSLock alloc] init];
     self.lock.name = AFURLSessionManagerLockName;
 
-    __weak typeof(self) weakSelf = self;
     [self.session getTasksWithCompletionHandler:^(NSArray *dataTasks, NSArray *uploadTasks, NSArray *downloadTasks) {
-
-        __strong typeof(weakSelf) strongSelf = weakSelf;
         for (NSURLSessionDataTask *task in dataTasks) {
-            [strongSelf addDelegateForDataTask:task uploadProgress:nil downloadProgress:nil completionHandler:nil];
+            [self addDelegateForDataTask:task uploadProgress:nil downloadProgress:nil completionHandler:nil];
         }
 
         for (NSURLSessionUploadTask *uploadTask in uploadTasks) {
-            [strongSelf addDelegateForUploadTask:uploadTask progress:nil completionHandler:nil];
+            [self addDelegateForUploadTask:uploadTask progress:nil completionHandler:nil];
         }
 
         for (NSURLSessionDownloadTask *downloadTask in downloadTasks) {
-            [strongSelf addDelegateForDownloadTask:downloadTask progress:nil destination:nil completionHandler:nil];
+            [self addDelegateForDownloadTask:downloadTask progress:nil destination:nil completionHandler:nil];
         }
     }];
 

diff --git a/Example/Today Extension Example/TodayViewController.m b/Example/Today Extension Example/TodayViewController.m
@@ -50,7 +50,6 @@ - (void)viewWillAppear:(BOOL)animated {
 - (void)widgetPerformUpdateWithCompletionHandler:(void (^)(NCUpdateResult))completionHandler {
     [Post globalTimelinePostsWithBlock:^(NSArray *posts, NSError *error) {
         if (!error) {
-
             self.post = posts.firstObject;
             [self savePost:self.post];
 

diff --git a/Example/macOS Example/AppDelegate.m b/Example/macOS Example/AppDelegate.m
@@ -46,8 +46,10 @@ - (void)applicationDidFinishLaunching:(NSNotification *)notification {
         self.postsArrayController.content = posts;
     }];
 
+    __weak __typeof(self)weakSelf = self;
     [[NSNotificationCenter defaultCenter] addObserverForName:kUserProfileImageDidLoadNotification object:nil queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *notification) {
-        [self.tableView reloadData];
+        __strong __typeof(weakSelf)strongSelf = weakSelf;
+        [strongSelf.tableView reloadData];
     }];
 }