[AMD] Supporting fused kernels build using JIT #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quentin-Anthony
approved these changes
Apr 1, 2024
|
@Quentin-Anthony should we update the README to reflect this change? |
Yes. We're on it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to enable JIT compilation for fused kernels on AMD GPUs, so that the same code will run on both AMD and NVIDIA GPUs.
Previous
python setup.py installmethod has issues with hipifying files, which results in ninja generating multiple rules for the same target.This will also make the extra fused kernel building instruction in the readme unnecessary. I will take care of the readme parts once this get approved
test_fused_kernels.pypassed#954
Reference: microsoft/Megatron-DeepSpeed@b4d4a0e