fix: Fix breaking EigenStepper change (acts-project#3223)

In acts-project#2846 I removed a constructor parameter which was used by Athena and maybe other clients. This would classify as a breaking change. To work around that I reintroduced the parameter and marked the constructor as deprecated.
EleniXoch · May 31, 2024 · 25fa54b · 25fa54b
1 parent ad2aabd
commit 25fa54b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/Core/include/Acts/Propagator/EigenStepper.hpp b/Core/include/Acts/Propagator/EigenStepper.hpp
@@ -162,7 +162,11 @@ class EigenStepper {
   };
 
   /// Constructor requires knowledge of the detector's magnetic field
-  EigenStepper(std::shared_ptr<const MagneticFieldProvider> bField);
+  /// @param bField The magnetic field provider
+  /// @param overstepLimit The limit for the overstep check
+  /// @note `overstepLimit` will be removed in a future release
+  explicit EigenStepper(std::shared_ptr<const MagneticFieldProvider> bField,
+                        double overstepLimit = 100 * UnitConstants::um);
 
   State makeState(std::reference_wrapper<const GeometryContext> gctx,
                   std::reference_wrapper<const MagneticFieldContext> mctx,

diff --git a/Core/include/Acts/Propagator/EigenStepper.ipp b/Core/include/Acts/Propagator/EigenStepper.ipp
@@ -15,7 +15,8 @@
 
 template <typename E, typename A>
 Acts::EigenStepper<E, A>::EigenStepper(
-    std::shared_ptr<const MagneticFieldProvider> bField)
+    std::shared_ptr<const MagneticFieldProvider> bField,
+    double /*overstepLimit*/)
     : m_bField(std::move(bField)) {}
 
 template <typename E, typename A>