swap: calculate required balance including fee #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During swap-out, conduct a pre-swap check, including the payment of the fee invoice.
|
LND swap-out is canceled but the error peerswap prints is unclear: LND logs: CLN swap-out is also canceled and the error message is more clear: |
The prepayment probe, which includes the expected payment amount for the fee invoice, is conducted at the start of the swapout. The prepayment probe at this stage is inaccurate and may cause unnecessary communication, so it will be removed.
Fixes the calculation of the SpendableMsat and ReceivableMsat.
|
Thank you. I confirmed that the behavior is as expected on our end. ./bin/lncli lnd1 listchannels | jq '.channels[] | {local_balance, local_chan_reserve_sat}'
{
"local_balance": "99996530",
"local_chan_reserve_sat": "1000000"
}result=$(./bin/lncli lnd1 listchannels | jq -r '.channels[] | (.local_balance | tonumber) - (.local_chan_reserve_sat | tonumber)')
AMOUNT=$((result - 200))
./out/pscli swapout --channel_id 127543348887553 --sat_amt $AMOUNT --asset lbtc
2024/07/19 11:07:50 rpc error: code = Unknown desc = not enough spendable msat: 98996530000, expected: 98996630000 |
|
It looks like my error slightly differs from yours? Yours: Mine: |
|
The cause is due to the difference in where the error is detected. My error passes the check at the SwapOut start stage and is detected at the PayFeeInvoiceAction stage, which is part of the recent changes. |
nepet
approved these changes
Jul 25, 2024
| @@ -131,7 +131,7 @@ func (l *Client) SpendableMsat(scid string) (uint64, error) { | |||
| return 0, err | |||
| } | |||
| spendable := (uint64(ch.GetLocalBalance()) - | |||
| ch.GetLocalConstraints().GetChanReserveSat()*1000) | |||
| ch.GetLocalConstraints().GetChanReserveSat()) * 1000 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During swap-out, conduct a pre-swap check, including the payment of the fee invoice.