Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcwallet: change getaddress to request a blech32 address #257

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

delta1
Copy link
Member

@delta1 delta1 commented Nov 18, 2023

requires ElementsProject/glightning#11 which adds the new addrtype to the rpc client library

fixes #256

@wtogami
Copy link
Contributor

wtogami commented Nov 20, 2023

Just checking do past UTXO's in your wallet continue to be spendable after this?

@delta1
Copy link
Member Author

delta1 commented Nov 20, 2023

I believe so, this only affects what type of address is requested from the elementsd node. This should behave exactly the same way as elements 22, before this change in 23 ElementsProject/elements#1246

@wtogami
Copy link
Contributor

wtogami commented Nov 20, 2023

Does peerswap remain compatible with elements v22 after this change?

@delta1
Copy link
Member Author

delta1 commented Nov 20, 2023

yes it should

@grubles
Copy link
Collaborator

grubles commented Nov 20, 2023

Tested ACK. 4b86b8a

Tested L-BTC (testnet) swaps with the mentioned glightning patch + this PR against both Elements v22 and the 23.x branch.

Tested mainnet L-BTC swaps too. Worked with both v22 and v23.x.

@jamesdorfman
Copy link
Contributor

Tested ACK 4b86b8a.

Successfully executed a swap between testnet L-BTC and signet BTC, using the patch in ElementsProject/glightning#11 along with elements-23.2.1rc3.

@wtogami
Copy link
Contributor

wtogami commented Dec 8, 2023

Is this still stuck due to a CI error?

@delta1
Copy link
Member Author

delta1 commented Dec 8, 2023

force pushed to get CI to run. same diff just used --reset-author to update date/time and commit hash

includes the updated glightning dependency
@delta1
Copy link
Member Author

delta1 commented Dec 8, 2023

force pushed again after updating the glightning dependency to ElementsProject/glightning@e32b4da

@wtogami wtogami merged commit 600c73d into ElementsProject:master Dec 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PeerSwap creates unblinded addresses with Elements v23
4 participants