-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpcwallet: change getaddress to request a blech32 address #257
Conversation
Just checking do past UTXO's in your wallet continue to be spendable after this? |
I believe so, this only affects what type of address is requested from the elementsd node. This should behave exactly the same way as elements 22, before this change in 23 ElementsProject/elements#1246 |
Does peerswap remain compatible with elements v22 after this change? |
yes it should |
Tested ACK. 4b86b8a Tested L-BTC (testnet) swaps with the mentioned Tested mainnet L-BTC swaps too. Worked with both v22 and v23.x. |
Tested ACK 4b86b8a. Successfully executed a swap between testnet L-BTC and signet BTC, using the patch in ElementsProject/glightning#11 along with elements-23.2.1rc3. |
Is this still stuck due to a CI error? |
force pushed to get CI to run. same diff just used |
includes the updated glightning dependency
force pushed again after updating the glightning dependency to ElementsProject/glightning@e32b4da |
requires ElementsProject/glightning#11 which adds the new addrtype to the rpc client library
fixes #256