Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile protobufs in docker #252

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

YusukeShimizu
Copy link
Contributor

@YusukeShimizu YusukeShimizu commented Oct 22, 2023

This is an improvement in the development experience.
No behavior changes.

This commit aims to make it easier to compile protobuf.
No need to have whole set of binaries and libraries all pinned to specific versions.

@YusukeShimizu YusukeShimizu marked this pull request as ready for review October 22, 2023 02:02
This commit aims to make it easier to compile protobuf.
Only need to have docker installed instead of
a whole set of binaries and libraries all pinned to very
specific versions.
@YusukeShimizu YusukeShimizu force-pushed the docker-rpc-compile branch 3 times, most recently from dc76b09 to 98b613b Compare October 22, 2023 03:43
@YusukeShimizu YusukeShimizu changed the title [peerswaprpc]Implemented to be able to compile protobufs in docker compile protobufs in docker Oct 22, 2023
Copy link
Contributor

@nepet nepet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! even though I would prefer nix for reproducibility issues ;)
This will be a major improvement for new devs.
ACK 98b613b

@wtogami wtogami merged commit 5a35f88 into ElementsProject:master Oct 28, 2023
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants