CLN deprecation/removal causes peerswap polls to not be sent to peers

[grubles]

In CLN v24.11, a change seems to be preventing sending peerswap poll messages to other peers. Normally, this shouldn't be much of an issue.

However, when a peer upgrades to a new protocol version (such as v4), then if it can't tell its peers it has upgraded via a poll message, they will still consider it on the previous incompatible version and refuse to swap.

2024-12-16T00:31:03.814Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T00:31:55.630Z INFO    plugin-peerswap: [FSM] Action failure incompatible peerswap version
2024-12-16T00:31:55.637Z INFO    plugin-peerswap: [Swap:12a26b285c88babfb921e087b389721ad2f50d181a11b2e136e229a3bf2a418f] Swap canceled. Reason: incompatible peerswap version

The Invalid parameter node_id messages seem to happen every 2-4 minutes for me:

2024-12-16T15:01:39.348Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:06:41.022Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:10:20.236Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:11:42.457Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:16:46.809Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:21:48.892Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:23:07.101Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:25:23.137Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:26:52.108Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:31:03.248Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:31:18.554Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:31:54.637Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:34:22.664Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:36:56.426Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:41:59.513Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:47:01.545Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'

[grubles]

Ok I realized today I never copied the updated peerswap plugin binary to the CLN plugins directory, so I was running an older version when trying to swap with an updated peer. So that part at least is a false alarm.

[YusukeShimizu]

The messages of the "connect" and "disconnect" events are no longer able to retrieve the peerID due to them being located in the "configs" sub-object that contains the details of each config setting, rather than being direct members with the same name as the config variable. This is believed to be causing failures in polling processing during peer connection. Please refer the link below for more details.
https://github.com/ElementsProject/lightning/blob/84f30b12f789937f0b0653892f5ba6ca3480aca8/doc/developers-guide/deprecations.md

This issue is being fixed in the following pull request.
#334