Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendcustommsg: Invalid parameter node_id (should be a node id): token '""' #7950

Closed
grubles opened this issue Dec 17, 2024 · 4 comments
Closed

Comments

@grubles
Copy link
Contributor

grubles commented Dec 17, 2024

Based on my logs, since around October 3rd (since I track master) these error messages have been appearing. I've scoured the changelog and the deprecations page but can't find anything obvious. The messages seem to occur every 2-4 minutes on a mediumish sized node and it's unclear if it's related to a plugin since the errors seemed to start after upgrading CLN.

Where was this change made?

2024-12-16T15:01:39.348Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:06:41.022Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:10:20.236Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:11:42.457Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:16:46.809Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:21:48.892Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:23:07.101Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:25:23.137Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:26:52.108Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:31:03.248Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:31:18.554Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:31:54.637Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:34:22.664Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:36:56.426Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:41:59.513Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-16T15:47:01.545Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
@grubles
Copy link
Contributor Author

grubles commented Dec 17, 2024

Maybe a clue?

Looking more closely at my logs, it seems there is always a separate error that occurs ~10 seconds before the sendcustommsg error. Example:

2024-12-17T19:32:54.820Z UNUSUAL 02cca6c5c966fcf61d121e3a70e03a1cd9eeeea024b26ea666ce974d43b242e636-lightningd: Unknown channel 6302bddeae50d362ae559120ad911053d6cc220090b8453238dc96c8fd907d71 for WIRE_ERROR
2024-12-17T19:33:04.528Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-17T19:37:56.359Z UNUSUAL 02cca6c5c966fcf61d121e3a70e03a1cd9eeeea024b26ea666ce974d43b242e636-lightningd: Unknown channel 6302bddeae50d362ae559120ad911053d6cc220090b8453238dc96c8fd907d71 for WIRE_ERROR
2024-12-17T19:38:06.060Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-17T19:41:24.056Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-17T19:42:59.580Z UNUSUAL 02cca6c5c966fcf61d121e3a70e03a1cd9eeeea024b26ea666ce974d43b242e636-lightningd: Unknown channel 6302bddeae50d362ae559120ad911053d6cc220090b8453238dc96c8fd907d71 for WIRE_ERROR
2024-12-17T19:43:09.074Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-17T19:48:01.847Z UNUSUAL 02cca6c5c966fcf61d121e3a70e03a1cd9eeeea024b26ea666ce974d43b242e636-lightningd: Unknown channel 6302bddeae50d362ae559120ad911053d6cc220090b8453238dc96c8fd907d71 for WIRE_ERROR
2024-12-17T19:48:11.403Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-17T19:48:23.011Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-17T19:50:24.683Z UNUSUAL lightningd: Bad gossip order: could not find channel 689377x512x0 for peer's channel update
2024-12-17T19:53:05.714Z UNUSUAL 02cca6c5c966fcf61d121e3a70e03a1cd9eeeea024b26ea666ce974d43b242e636-lightningd: Unknown channel 6302bddeae50d362ae559120ad911053d6cc220090b8453238dc96c8fd907d71 for WIRE_ERROR
2024-12-17T19:53:15.105Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-12-17T19:58:08.766Z UNUSUAL 02cca6c5c966fcf61d121e3a70e03a1cd9eeeea024b26ea666ce974d43b242e636-lightningd: Unknown channel 6302bddeae50d362ae559120ad911053d6cc220090b8453238dc96c8fd907d71 for WIRE_ERROR
2024-12-17T19:58:17.769Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'

@grubles
Copy link
Contributor Author

grubles commented Dec 17, 2024

I've stopped the peerswap plugin and haven't seen one of these errors since, but the question remains -- what has changed recently that would cause it to send an empty node id?

@grubles
Copy link
Contributor Author

grubles commented Dec 18, 2024

Okay I apparently didn't look at the deprecations page hard enough.

ElementsProject/peerswap#333 (comment)

@grubles
Copy link
Contributor Author

grubles commented Dec 19, 2024

Closing as fixed in ElementsProject/peerswap#334

@grubles grubles closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant