reckless update: enable install @ commit and add python virtual environments #7018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endothermicdev
force-pushed
the
reckless-python-venv
branch
2 times, most recently
from
bd8d730
to
51da432
Compare
|
I removed timeouts on the pip and poetry install (grpcio took a very long time to build) and reenabled streaming output. Expanded test coverage of the installed poetry environment and forced poetry installation into a new virtual environment by removing the VIRTUAL_ENV environment variable. Without this Poetry was preferring the already active (CI) venv and merely updating it. |
endothermicdev
force-pushed
the
reckless-python-venv
branch
2 times, most recently
from
ba7a37d
to
0e0c3b5
Compare
Fixes a bug introduced in 6163138 which avoided gratuitous rewrites of the lightningd config
This creates a separate staging directory from the one used to clone the source. A symlink is then added to the plugin's entrypoint which is now in the source directory.
endothermicdev
force-pushed
the
reckless-python-venv
branch
2 times, most recently
from
e9b07e0
to
ece7b2d
Compare
The metadata includes an original retrieval source, timestamp, and commit hash. This will allow a future update command to more easily evaluate the status of the existing installation.
... using the syntax reckless install <plugin_name>@<commit hash>
endothermicdev
force-pushed
the
reckless-python-venv
branch
from
ece7b2d
to
26af072
Compare
This uses pip to install to a venv when the dependencies are specified
with requirements.txt and poetry when it's present on the system and the
plugin has a pyproject.toml.
The directory structure will be:
reckless/
source/ (original plugin code here)
plugin_entrypoint (original entrypoint)
plugin_name (symlink or wrapper to activate venv)
.metadata (installation information)
.venv/ (python virtual environment)
The wrapper matches the naming of the original plugin entrypoint. The
shebang is modified to use the virtual environment's python binary,
then the original plugin is imported as a module and executed as though
it was run directly.
Changelog-Changed: reckless installs python plugins in virtual environments
Also test checkout of a git tag on installation.
endothermicdev
force-pushed
the
reckless-python-venv
branch
from
26af072
to
1251743
Compare
cdecker
approved these changes
Feb 7, 2024
| assert n.rpc.testmethod() == 'I live.' | ||
|
|
||
|
|
||
| @unittest.skipIf(VALGRIND, "virtual environment triggers memleak detection") |
There was a problem hiding this comment.
Are all these skipped if VALGRIND is set? If yes there is a way to disable tests in the entire file with the following anywhere before the first test:
if VALGRIND:
pytest.skip(allow_module_level=True)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several reckless updates:
fixes an issue with removing sources from the reckless source list
refactors the installation process staging individual plugins in a separate directory from their cloned source
adds metadata to the installation directory - this will be used in a future 'update' command
adds the ability to install a specific commit or tag with @<tag/commit> syntax
creates individual python virtual environments using pip (requirements.txt) or poetry (pyproject.toml)