startup_regtest.sh: updates + improvements #6898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/startup-directory-cleanup
branch
from
1638332 to
51e9972
Compare
We were using similar variables for different things (directories vs binary). Update this to separate them out, while also adding ability to use a different directory for lightning nodes Changelog-Changed: startup_regtest.sh PATH_TO_LIGHTNING + PATH_TO_BITCOIN are no more. Use LIGHTNING_BIN and BITCOIN_DIR
niftynei
force-pushed
the
nifty/startup-directory-cleanup
branch
from
51e9972 to
19b71a2
Compare
Now that 'developer' isn't a compile time flag, let's always use it when using the startup regtest nodes. Should always make gossip + polling bitcoind fast
Changelog-Changed: startup_regtest.sh: `fund_nodes` will now make balanced channels
niftynei
force-pushed
the
nifty/startup-directory-cleanup
branch
from
19b71a2 to
a4f711d
Compare
vincenzopalazzo
approved these changes
Dec 2, 2023
| funder-min-their-funding=10000 | ||
| funder-per-channel-max=100000 | ||
| funder-fuzz-percent=0 | ||
| funder-lease-requests-only=false |
There was a problem hiding this comment.
nit: tab missing here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few updates to the startup_regtest.sh utility.
PATH_TO_LIGHTNINGandPATH_TO_BITCOINLIGHTNING_BIN,LIGHTNING_DIR,BITCOIN_BIN,BITCOIN_DIR. Now you can set where bitcoind/bitcoin datadir/lightningd/lightning-dir are!funderto always contribute fundsfund_nodesto fund the 2nd node so it makes balanced channels by default