Remove pyln-client json monkey patch for _msat fields to Millisatoshis #6865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the class interacts with int very well now, we don't have to make explicit accesses, so it's easy to write code which works with Millisatoshi or int. Also, don't access rpc.decoder in one test, it's unnecessary. Signed-off-by: Rusty Russell <[email protected]>
Now _msat fields are all integers (last conversion 23.08) we can simply leave them alone, rather than trying to convert them. And for turning Millisatoshi into JSON, we simply globally replace the default encoding function to try ".to_json()" on items, which allows anything to be marshalled. The global replacement was interfering with other uses of JSON, such as the clnrest plugin. Signed-off-by: Rusty Russell <[email protected]> Changelog-Changed: pyln-client: no longer autoconverts _msat field to Millisatoshi class (leaves as ints).
rustyrussell
force-pushed
the
guilt/remove-json-monkey-patch
branch
from
bc447b2 to
1123fee
Compare
|
Trivial rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was interfering with other JSON usages (confusingly!) such as clnrest. We only did it because _msat fields used to be strings.
Leaves the generic fallback to ".to_json" to marshall into JSON though.