Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the capability of decode RPC to decrypt the contents of emergency.recover file. #6773

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

adi2011
Copy link
Collaborator

@adi2011 adi2011 commented Oct 14, 2023

This RPC method would help users to verify if the backup stored in emergencyrecover and peer_storage is valid and up-to-data. As requested in issue #6711.

Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We should add some docs about these commands, and I think also
some use cases when the user should use the emergency.recover in general.

Are you planning to do something like this?

plugins/chanbackup.c Outdated Show resolved Hide resolved
plugins/chanbackup.c Outdated Show resolved Hide resolved
plugins/chanbackup.c Outdated Show resolved Hide resolved
plugins/chanbackup.c Outdated Show resolved Hide resolved
plugins/chanbackup.c Outdated Show resolved Hide resolved
plugins/chanbackup.c Outdated Show resolved Hide resolved
@adi2011 adi2011 force-pushed the verifybackup branch 4 times, most recently from 7e529eb to 041e02b Compare October 15, 2023 19:14
@adi2011 adi2011 changed the title RPC method verifybackup to check the data within emergency.recover and peer_storage. Extend the capability of decode RPC to decrypt the contents of emergency.recover file. Oct 15, 2023
@adi2011 adi2011 force-pushed the verifybackup branch 3 times, most recently from 692cd26 to a33da43 Compare October 16, 2023 20:37
@rustyrussell rustyrussell added this to the v23.11 milestone Oct 16, 2023
@adi2011 adi2011 force-pushed the verifybackup branch 9 times, most recently from 2b16f6e to 891c5a3 Compare October 21, 2023 08:47
@adi2011 adi2011 requested a review from cdecker as a code owner October 21, 2023 08:47
@adi2011 adi2011 force-pushed the verifybackup branch 4 times, most recently from ce67f11 to 403ef06 Compare October 23, 2023 06:30
Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes only...

plugins/offers.c Outdated Show resolved Hide resolved
plugins/offers.c Outdated Show resolved Hide resolved
plugins/offers.c Outdated Show resolved Hide resolved
plugins/offers.c Outdated Show resolved Hide resolved
doc/lightning-decode.7.md Outdated Show resolved Hide resolved
@adi2011 adi2011 force-pushed the verifybackup branch 3 times, most recently from 7e64356 to 6f7d154 Compare October 25, 2023 08:07
@adi2011 adi2011 force-pushed the verifybackup branch 2 times, most recently from 4e282a8 to 8f26191 Compare October 25, 2023 13:11
Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just add some Changelog-Added lines, and squash regen commits (I need to rebase on master now, since other things got merged)

@rustyrussell
Copy link
Contributor

Oh, and I changed "encrypted blob" from decode to "emergency recover" which is more specific!

@adi2011
Copy link
Collaborator Author

adi2011 commented Oct 26, 2023

Great, Just needed to change the type given out in the result. Hopefully CI would be happy now.

@adi2011 adi2011 force-pushed the verifybackup branch 3 times, most recently from c5afa23 to f40acf1 Compare October 26, 2023 09:24
plugins/offers.c Outdated Show resolved Hide resolved
Aditya Sharma and others added 4 commits October 27, 2023 09:30
…ts of emergency.recover file.

Changelog-Added: JSON-RPC: `decode` can now decide emergency.recover files (clnemerg1...)
…in bech32 format.

Changelog-Added: `hsmtool`: new command `getemergencyrecover` to extract emergency.recover in bech32 format (clnemerge1...)
@rustyrussell rustyrussell merged commit 34692ec into ElementsProject:master Oct 27, 2023
38 checks passed
ShahanaFarooqui added a commit to ShahanaFarooqui/lightning that referenced this pull request Nov 10, 2023
ShahanaFarooqui added a commit to ShahanaFarooqui/lightning that referenced this pull request Nov 10, 2023
nepet pushed a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants