Restore any missing psbt metadata that resource constrained signers strip #6767
Conversation
|
@vincenzopalazzo The CI failure I'm seeing here doesn't seem related to us? Wonder if everyone is seeing it ... |
ksedgwic
force-pushed
the
restore-signed-psbt-metadata
branch
from
fc0d706
to
0837e86
Compare
| if (wally_psbt_clone_alloc(psbt0, 0, &combined_psbt) != WALLY_OK) | ||
| abort(); | ||
| if (wally_psbt_combine(combined_psbt, psbt1) != WALLY_OK) { | ||
| tal_wally_end_onto(ctx, combined_psbt, struct wally_psbt); |
There was a problem hiding this comment.
Is this the right thing to do here? Should we free the memory immediately instead?
There was a problem hiding this comment.
I think this is right, because from the docs of tal_wally_end_onto I found that
this method iterates over an object allocated by libwally. So I guess it is the safe way to delete an object that wally worked on?
There was a problem hiding this comment.
This works, but leaks the combined_psbt. You should return tal_free(combined_psbt); after this (of course, this code shouldn't happen at all, since the HSM said the PSBT was good!).
| if (wally_psbt_clone_alloc(psbt0, 0, &combined_psbt) != WALLY_OK) | ||
| abort(); | ||
| if (wally_psbt_combine(combined_psbt, psbt1) != WALLY_OK) { | ||
| tal_wally_end_onto(ctx, combined_psbt, struct wally_psbt); |
There was a problem hiding this comment.
This works, but leaks the combined_psbt. You should return tal_free(combined_psbt); after this (of course, this code shouldn't happen at all, since the HSM said the PSBT was good!).
…trip Fixes ([ElementsProject#6764]) Changelog-Fixed: Restore any missing metadata that resource constrained signers stripped
ksedgwic
force-pushed
the
restore-signed-psbt-metadata
branch
from
0837e86
to
f86efbe
Compare
vincenzopalazzo
merged commit 39e17ff
into
ElementsProject:master
Fixes #6764
This is an alternate approach to #6766 . By combining the signed psbt back into the
pre-signed psbt any metadata that a resource constrained signer (VLS) strips (
input.utxo) will be restored.