runes: Reimplement rate in terms of per
#6710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
force-pushed
the
rate-as-per
branch
from
f765ee0
to
6722788
Compare
We test this in test_runes, so make this test more cursory (otherwise next patch breaks it). Signed-off-by: Rusty Russell <[email protected]>
Changelog-Changed: JSON-RPC: `checkrune` `rate` restriction is slightly stricter (exact division of time like `per`)
rustyrussell
force-pushed
the
rate-as-per
branch
from
6722788
to
12a583d
Compare
|
We missed a rune test, so I added a prior commit which reduces it (it was fairly redundant now anyway) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog-Changed: JSON-RPC:
checkruneraterestriction is slightly stricter (exact division of time likeper)